Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G gitlabhq1
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gpt
  • large_projects
  • gitlabhq1
  • Issues
  • #7310

Closed
Open
Created Jul 15, 2014 by Administrator@rootOwner

Hide "Diff comments" and "Edit" on merge request diffs for binary files.

Created by: cirosantilli

"Diff comments" obviously makes no sense in that case.

It would be cool to "Edit" any binary files e.g. convert it to hex or something, but as it currently stands it is too broken to be shown to end users: it opens on the editor, bu for example non printable chars like \0 simply disappear from the view.

Live sample: https://gitlab.com/cirosantilli/testme/merge_requests/1/diffs

Screenshot:

screenshot from 2014-07-15 18 28 06 binary file edit diff comments

Assignee
Assign to
Time tracking