Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G gitlabhq1
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gpt
  • large_projects
  • gitlabhq1
  • Merge requests
  • !1232

Merged
Created Aug 14, 2012 by Administrator@rootOwner

GFM Refactoring

  • Overview 6
  • Commits 3
  • Changes 2

Created by: rspeicher

According to cane, the gfm helper method was by far the most complex method in the entire project, so I tried to refactor it a bit.

I think the new one is a bit easier to understand and will be easier to maintain, especially for the regex pattern.

This also shows that there's still lots of room for improvement, particularly removing the duplication from dealing with html_options and the various link classes. I'll reply to this with some ideas.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: github/fork/rspeicher/refactor_gfm