Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G gitlabhq1
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gpt
  • large_projects
  • gitlabhq1
  • Merge requests
  • !3647

Closed
Created Apr 20, 2013 by Administrator@rootOwner
  • Report abuse
Report abuse

Attempt at #3022 - More complex implementation

  • Overview 2
  • Commits 4
  • Changes 2

Created by: brocktimus

As per #3022 (closed) I'm trying to add procs to the gitlab configuration that adjust how LDAP attributes are mapped to users. There are two implementations and pull requests because I'm unsure which is better and I should go down the route of writing tests for. The other pull request is #3646.

In this implementation I thought the create from omniauth function was getting somewhat complex. Tried to pull some of the more complex stuff out into its own helper class as can be seen. Quite a bit of code removed and then a "large" class added to try and simplify code and interface.

Unsure if it is better or not, hence creating the other implementation with less changes.

/cc @senny

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: github/fork/brocktimus/more_procs