Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G gitlabhq1
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gpt
  • large_projects
  • gitlabhq1
  • Merge requests
  • !7657

Merged
Created Aug 31, 2014 by Administrator@rootOwner

[refactor] Factor out commit list from compare and new MR.

  • Overview 8
  • Commits 1
  • Changes 3

Created by: cirosantilli

The exact same piece of code was copied twice.

Besides those, there is also a third very similar copy which has started to diverge for the merge requests show view at: https://github.com/gitlabhq/gitlabhq/blob/174c00cf2c026a3bdc61d94b45195a5e5c99202f/app/views/projects/merge_requests/show/_commits.html.haml#L6 . It has diverged as it now:

  • has a list icon
  • hides to 8 items on page load

I propose all of those 3 cases be made the same. If not, at least we should further refactor part of the MR show with the other 2 occurrences.

Just to show clearly what is the object in question:

screenshot from 2014-08-31 13 07 27 commit list

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: github/fork/cirosantilli/factor-commit-list